From 2ad89b72b5798219dd53e79eacc7a9dc92a5e41b Mon Sep 17 00:00:00 2001 From: Jasraj Chouhan <106804923+JasrajChouhan@users.noreply.github.com> Date: Thu, 31 Jul 2025 19:40:41 +0530 Subject: [PATCH] fix: show proper error messages on auth failure in Next.js frontend (#445) Co-authored-by: Aman Varshney --- .changeset/hip-lands-fix.md | 5 +++++ .../auth/web/react/next/src/components/sign-in-form.tsx | 2 +- .../auth/web/react/next/src/components/sign-up-form.tsx | 2 +- .../web/react/react-router/src/components/sign-in-form.tsx | 2 +- .../web/react/react-router/src/components/sign-up-form.tsx | 2 +- .../react/tanstack-router/src/components/sign-in-form.tsx | 2 +- .../react/tanstack-router/src/components/sign-up-form.tsx | 2 +- .../web/react/tanstack-start/src/components/sign-in-form.tsx | 2 +- .../web/react/tanstack-start/src/components/sign-up-form.tsx | 2 +- bun.lock | 2 +- 10 files changed, 14 insertions(+), 9 deletions(-) create mode 100644 .changeset/hip-lands-fix.md diff --git a/.changeset/hip-lands-fix.md b/.changeset/hip-lands-fix.md new file mode 100644 index 0000000..27fc4f3 --- /dev/null +++ b/.changeset/hip-lands-fix.md @@ -0,0 +1,5 @@ +--- +"create-better-t-stack": patch +--- + +fix auth error handling in all react templates diff --git a/apps/cli/templates/auth/web/react/next/src/components/sign-in-form.tsx b/apps/cli/templates/auth/web/react/next/src/components/sign-in-form.tsx index 3b8861a..ff0e804 100644 --- a/apps/cli/templates/auth/web/react/next/src/components/sign-in-form.tsx +++ b/apps/cli/templates/auth/web/react/next/src/components/sign-in-form.tsx @@ -33,7 +33,7 @@ export default function SignInForm({ toast.success("Sign in successful"); }, onError: (error) => { - toast.error(error.error.message); + toast.error(error.error.message || error.error.statusText); }, }, ); diff --git a/apps/cli/templates/auth/web/react/next/src/components/sign-up-form.tsx b/apps/cli/templates/auth/web/react/next/src/components/sign-up-form.tsx index ce436ca..e9b7348 100644 --- a/apps/cli/templates/auth/web/react/next/src/components/sign-up-form.tsx +++ b/apps/cli/templates/auth/web/react/next/src/components/sign-up-form.tsx @@ -35,7 +35,7 @@ export default function SignUpForm({ toast.success("Sign up successful"); }, onError: (error) => { - toast.error(error.error.message); + toast.error(error.error.message || error.error.statusText); }, }, ); diff --git a/apps/cli/templates/auth/web/react/react-router/src/components/sign-in-form.tsx b/apps/cli/templates/auth/web/react/react-router/src/components/sign-in-form.tsx index f5b7edb..987d64e 100644 --- a/apps/cli/templates/auth/web/react/react-router/src/components/sign-in-form.tsx +++ b/apps/cli/templates/auth/web/react/react-router/src/components/sign-in-form.tsx @@ -33,7 +33,7 @@ export default function SignInForm({ toast.success("Sign in successful"); }, onError: (error) => { - toast.error(error.error.message); + toast.error(error.error.message || error.error.statusText); }, } ); diff --git a/apps/cli/templates/auth/web/react/react-router/src/components/sign-up-form.tsx b/apps/cli/templates/auth/web/react/react-router/src/components/sign-up-form.tsx index 97f1cdd..2ad0c76 100644 --- a/apps/cli/templates/auth/web/react/react-router/src/components/sign-up-form.tsx +++ b/apps/cli/templates/auth/web/react/react-router/src/components/sign-up-form.tsx @@ -35,7 +35,7 @@ export default function SignUpForm({ toast.success("Sign up successful"); }, onError: (error) => { - toast.error(error.error.message); + toast.error(error.error.message || error.error.statusText); }, } ); diff --git a/apps/cli/templates/auth/web/react/tanstack-router/src/components/sign-in-form.tsx b/apps/cli/templates/auth/web/react/tanstack-router/src/components/sign-in-form.tsx index 65bfab2..b9b3c05 100644 --- a/apps/cli/templates/auth/web/react/tanstack-router/src/components/sign-in-form.tsx +++ b/apps/cli/templates/auth/web/react/tanstack-router/src/components/sign-in-form.tsx @@ -37,7 +37,7 @@ export default function SignInForm({ toast.success("Sign in successful"); }, onError: (error) => { - toast.error(error.error.message); + toast.error(error.error.message || error.error.statusText); }, }, ); diff --git a/apps/cli/templates/auth/web/react/tanstack-router/src/components/sign-up-form.tsx b/apps/cli/templates/auth/web/react/tanstack-router/src/components/sign-up-form.tsx index 3bd480f..0ee113d 100644 --- a/apps/cli/templates/auth/web/react/tanstack-router/src/components/sign-up-form.tsx +++ b/apps/cli/templates/auth/web/react/tanstack-router/src/components/sign-up-form.tsx @@ -39,7 +39,7 @@ export default function SignUpForm({ toast.success("Sign up successful"); }, onError: (error) => { - toast.error(error.error.message); + toast.error(error.error.message || error.error.statusText); }, }, ); diff --git a/apps/cli/templates/auth/web/react/tanstack-start/src/components/sign-in-form.tsx b/apps/cli/templates/auth/web/react/tanstack-start/src/components/sign-in-form.tsx index 65bfab2..b9b3c05 100644 --- a/apps/cli/templates/auth/web/react/tanstack-start/src/components/sign-in-form.tsx +++ b/apps/cli/templates/auth/web/react/tanstack-start/src/components/sign-in-form.tsx @@ -37,7 +37,7 @@ export default function SignInForm({ toast.success("Sign in successful"); }, onError: (error) => { - toast.error(error.error.message); + toast.error(error.error.message || error.error.statusText); }, }, ); diff --git a/apps/cli/templates/auth/web/react/tanstack-start/src/components/sign-up-form.tsx b/apps/cli/templates/auth/web/react/tanstack-start/src/components/sign-up-form.tsx index 3bd480f..0ee113d 100644 --- a/apps/cli/templates/auth/web/react/tanstack-start/src/components/sign-up-form.tsx +++ b/apps/cli/templates/auth/web/react/tanstack-start/src/components/sign-up-form.tsx @@ -39,7 +39,7 @@ export default function SignUpForm({ toast.success("Sign up successful"); }, onError: (error) => { - toast.error(error.error.message); + toast.error(error.error.message || error.error.statusText); }, }, ); diff --git a/bun.lock b/bun.lock index 5693232..94686c3 100644 --- a/bun.lock +++ b/bun.lock @@ -14,7 +14,7 @@ }, "apps/cli": { "name": "create-better-t-stack", - "version": "2.28.0", + "version": "2.28.3", "bin": { "create-better-t-stack": "dist/index.js", },