From b91a1cbcf30b6170fd1097fc6668f3e0584fb4ed Mon Sep 17 00:00:00 2001 From: Adhiraj Singh Date: Thu, 25 Nov 2021 19:51:49 +0530 Subject: [PATCH] fix: possible leak on waitForMessage --- src/Socket/socket.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Socket/socket.ts b/src/Socket/socket.ts index 45323d7..522a873 100644 --- a/src/Socket/socket.ts +++ b/src/Socket/socket.ts @@ -123,12 +123,14 @@ export const makeSocket = ({ ws.on(`TAG:${msgId}`, onRecv) ws.on('close', onErr) // if the socket closes, you'll never receive the message + ws.off('error', onErr) }, ) return result as any } finally { ws.off(`TAG:${msgId}`, onRecv) ws.off('close', onErr) // if the socket closes, you'll never receive the message + ws.off('error', onErr) } } /** send a query, and wait for its response. auto-generates message ID if not provided */